Re: [PATCH 01/25] media: iris: Fix buffer count reporting in internal buffer check

[Bryan O'Donoghue]

On 04/07/2025 08:53, Dikshita Agarwal wrote:
> Initialize the count variable to zero before counting unreleased
> internal buffers in iris_check_num_queued_internal_buffers().
> This prevents stale values from previous iterations and ensures accurate
> error reporting for each buffer type. Without this initialization, the
> count could accumulate across types, leading to incorrect log messages.
>
> Fixes: d2abb1ff5a3c ("media: iris: Verify internal buffer release on close")
> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
> ---
>   drivers/media/platform/qcom/iris/iris_vidc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
> index c417e8c31f806e03555cd5e2a662a6efe5d58f3e..8285bdaf9466d4bea0f89a3b1943ed7d6c014b7d 100644
> --- a/drivers/media/platform/qcom/iris/iris_vidc.c
> +++ b/drivers/media/platform/qcom/iris/iris_vidc.c
> @@ -240,6 +240,7 @@ static void iris_check_num_queued_internal_buffers(struct iris_inst *inst, u32 p
>   
>   	for (i = 0; i < internal_buffer_count; i++) {
>   		buffers = &inst->buffers[internal_buf_type[i]];
> +		count = 0;
>   		list_for_each_entry_safe(buf, next, &buffers->list, list)
>   			count++;
>   		if (count)
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>