Re: [PATCH] mm/hugetlb: Use max() to simplify hugetlb_vmemmap_optimizable_size()

From: David Hildenbrand
Date: Mon Aug 11 2025 - 05:16:05 EST


On 11.08.25 11:08, Thorsten Blum wrote:
On 11. Aug 2025, at 10:26, David Hildenbrand wrote:
On 11.08.25 02:15, Matthew Wilcox wrote:
On Sun, Aug 10, 2025 at 11:47:45PM +0200, Thorsten Blum wrote:
Use max() to simplify hugetlb_vmemmap_optimizable_size() and improve its
readability.
That ... isn't clearer.

No, it isn't.

I guess it's personal preference. I'd prefer max(0, x) over a ternary
operator any time.

if (size > 0)
return size;
/* Nothing can be optimized out. */
return 0;

--
Cheers,

David / dhildenb