Re: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
From: Dan Carpenter
Date: Mon Aug 11 2025 - 03:01:41 EST
Hi Bijan,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Bijan-Tabatabai/mm-damon-core-Add-damos_destroy_dests/20250806-120845
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250805162022.4920-3-bijan311%40gmail.com
patch subject: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
config: microblaze-randconfig-r072-20250810 (https://download.01.org/0day-ci/archive/20250810/202508101330.XRQqvfiN-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202508101330.XRQqvfiN-lkp@xxxxxxxxx/
smatch warnings:
mm/damon/sysfs-schemes.c:2605 damos_sysfs_set_schemes_dests() warn: iterator 'i' not incremented
vim +/i +2605 mm/damon/sysfs-schemes.c
8014d822c9939b Bijan Tabatabai 2025-08-05 2601 int damos_sysfs_set_schemes_dests(struct damon_sysfs_schemes *sysfs_schemes,
8014d822c9939b Bijan Tabatabai 2025-08-05 2602 struct damon_ctx *ctx)
8014d822c9939b Bijan Tabatabai 2025-08-05 2603 {
8014d822c9939b Bijan Tabatabai 2025-08-05 2604 struct damos *scheme;
8014d822c9939b Bijan Tabatabai 2025-08-05 @2605 int i = 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2606
8014d822c9939b Bijan Tabatabai 2025-08-05 2607 damon_for_each_scheme(scheme, ctx) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2608 struct damos_sysfs_dests *sysfs_dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2609 struct damos_migrate_dests dests = {};
8014d822c9939b Bijan Tabatabai 2025-08-05 2610 int err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2611
8014d822c9939b Bijan Tabatabai 2025-08-05 2612 /* user could have removed the scheme sysfs dir */
8014d822c9939b Bijan Tabatabai 2025-08-05 2613 if (i >= sysfs_schemes->nr)
i is always zero.
8014d822c9939b Bijan Tabatabai 2025-08-05 2614 break;
8014d822c9939b Bijan Tabatabai 2025-08-05 2615
8014d822c9939b Bijan Tabatabai 2025-08-05 2616 sysfs_dests = sysfs_schemes->schemes_arr[i]->dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2617 err = damos_sysfs_add_migrate_dest(&dests, sysfs_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2618 if (err) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2619 damos_destroy_dests(&dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2620 return err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2621 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2622
8014d822c9939b Bijan Tabatabai 2025-08-05 2623 damos_destroy_dests(&scheme->migrate_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2624 scheme->migrate_dests = dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2625 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2626
8014d822c9939b Bijan Tabatabai 2025-08-05 2627 return 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2628 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki