Re: [PATCH v3 1/2] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
From: Krzysztof Kozlowski
Date: Mon Aug 11 2025 - 02:57:00 EST
On Fri, Aug 08, 2025 at 04:20:32PM +0300, Aman Kumar Pandey wrote:
> Add bindings for the NXP P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841)
> multiport I3C hub family. These devices connect to a host via
> I3C/I2C/SMBus and allow communication with multiple downstream
> peripherals.
>
> Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@xxxxxxx>
> Signed-off-by: Vikash Bansal <vikash.bansal@xxxxxxx>
>
> ---
> V1 -> V2: Cleaned up coding style and addressed review comments
Which ones?
You must be precise here.
> V2 -> V3: Added mfd device support for i3c hub and regulator.
Still not tested, still fails. :/ I will not review this, please reach
to your colleagues in NXP to explain how to test code before sending
upstream.
Best regards,
Krzysztof