Re: [PATCH net] rds: Fix endian annotations across various assignments
From: Ujwal Kundur
Date: Sun Aug 10 2025 - 15:31:33 EST
Thanks a lot for the explanation Al!
I was apprehensive about breaking things and in hindsight, should've
understood why the cast was present rather than accepting sparse's
report as the whole truth; Will go through the code more thoroughly
and send a v2 patchset.
> This smells of an LLM generated patch. So i think you are somewhat
> wasting your time explaining in detail why this is wrong.
I have never used (and will not use) LLMs :(
I intend to learn more about the networking stack through
contributions and I __strongly__ believe using LLMs / AI won't help me
get there.
> It took me about 60 seconds to prove the POLLERR change was wrong, and
> i know nothing about this code base. So it is in fact not a lot of
> effort.
I looked up the definition of POLLERR on Elixir [1] and it seemed like
a valid Sparse report to me. I wasn't aware of EPOLLERR, and now
realize all the other operations are prefixed with EPOLL* in af_rds.c.
I look forward to reviews/critiques to learn from them but being
accused of using LLMs is kinda disheartening.
P.S: I'm still learning the ropes as a contributor so please pardon my
ignorance.
[1] - https://elixir.bootlin.com/linux/v6.16/source/include/uapi/asm-generic/poll.h#L9