Re: [PATCH v7 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor

[Jonathan Cameron]

On Mon, 28 Jul 2025 09:54:43 +0200
Andreas Klinger <ak@xxxxxxxxxxxxx> wrote:

> This patchset adds an IIO driver for Vishay veml6046x00 RGBIR color sensor.
Tweaks as per comments on patch 2 and applied to the testing branch of iio.git.

I'll rebase on rc1 in the next few days and then push this out as a tree linux-next
picks up.

Thanks,

Jonathan

> 
> Changes in v7:
> - Thanks to the reviews of Jonathan and Andy improvements in the PM could be
>   implemented like removal of pm_runtime_mark_last_busy() and consistency in PM
>   handling in some functions.
> 
> Changes in v6:
> - Thanks to the in-depth review of Andy many datatype improvements were
>   realized.
> - According to Jonathans review change the channel types from IIO_LIGHT to
>   IIO_INTENSITY.
> 
> Changes in v5:
> - Thanks to the feedback of Andy and further explanations of Jonathan many
>   improvements could be implemented.
> - add documentation in kernel-doc format
> - iio_push_to_buffers_with_ts() is not used as also testing against
>   linux-stable where it is not available so far.
> 
> Changes in v4:
> - implement feedback from Andy and Jonathan
> - implement feedback from vendor (reading interrupt register as bulk read)
> 
> Changes in v3:
> - implement a lot of feedback from Jonathan
> - change scale value to real factor of lux per raw count instead of hardware
>   gain  
> - optimize code by using more lookup tables
> - remove unimplemented threshold functionality
> 
> Changes in v2:
> - fix missing include for example in vishay,veml6046x00.yaml
> 
> Andreas Klinger (3):
>   dt-bindings: iio: light: veml6046x00: add color sensor
>   iio: light: add support for veml6046x00 RGBIR color sensor
>   MAINTAINER: add maintainer for veml6046x00
> 
>  .../iio/light/vishay,veml6046x00.yaml         |   51 +
>  MAINTAINERS                                   |    6 +
>  drivers/iio/light/Kconfig                     |   13 +
>  drivers/iio/light/Makefile                    |    1 +
>  drivers/iio/light/veml6046x00.c               | 1031 +++++++++++++++++
>  5 files changed, 1102 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml
>  create mode 100644 drivers/iio/light/veml6046x00.c
>