Re: [PATCH 3/3] SUNRPC: Remove redundant __GFP_NOWARN

[Chuck Lever]

On 8/10/25 3:29 AM, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@xxxxxxxx>
> ---
>  net/sunrpc/socklib.c           | 2 +-
>  net/sunrpc/xprtrdma/rpc_rdma.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c
> index 4e92e2a50168..d8d8842c7de5 100644
> --- a/net/sunrpc/socklib.c
> +++ b/net/sunrpc/socklib.c
> @@ -86,7 +86,7 @@ xdr_partial_copy_from_skb(struct xdr_buf *xdr, struct xdr_skb_reader *desc)
>  		/* ACL likes to be lazy in allocating pages - ACLs
>  		 * are small by default but can get huge. */
>  		if ((xdr->flags & XDRBUF_SPARSE_PAGES) && *ppage == NULL) {
> -			*ppage = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> +			*ppage = alloc_page(GFP_NOWAIT);
>  			if (unlikely(*ppage == NULL)) {
>  				if (copied == 0)
>  					return -ENOMEM;
> diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
> index 1478c41c7e9d..3aac1456e23e 100644
> --- a/net/sunrpc/xprtrdma/rpc_rdma.c
> +++ b/net/sunrpc/xprtrdma/rpc_rdma.c
> @@ -190,7 +190,7 @@ rpcrdma_alloc_sparse_pages(struct xdr_buf *buf)
>  	ppages = buf->pages + (buf->page_base >> PAGE_SHIFT);
>  	while (len > 0) {
>  		if (!*ppages)
> -			*ppages = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> +			*ppages = alloc_page(GFP_NOWAIT);
>  		if (!*ppages)
>  			return -ENOBUFS;
>  		ppages++;

Acked-by: Chuck Lever <chuck.lever@xxxxxxxxxx>

-- 
Chuck Lever