Re: [PATCH v2] iio: Remove error prints for devm_add_action_or_reset()

From: Jonathan Cameron
Date: Sat Aug 09 2025 - 16:00:22 EST


On Tue, 5 Aug 2025 15:06:02 +0200
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Aug 5, 2025 at 11:33 AM Waqar Hameed <waqar.hameed@xxxxxxxx> wrote:
> >
> > When `devm_add_action_or_reset()` fails, it is due to a failed memory
> > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> > anything when error is `-ENOMEM`. Therefore, remove the useless call to
> > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> > return the value instead.
>
> Even more, the devm has tracepoints in case somebody really wants to
> investigate failures.
>
> Fully in support of this change.
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
>

Applied to the testing branch of iio.git. I'll rebase that
on rc1 once available.

Jonathan