Re: [PATCH v2] NFSD: Fix destination buffer size in nfsd4_ssc_setup_dul()

[Chuck Lever]

From: Chuck Lever <chuck.lever@xxxxxxxxxx>

On Wed, 06 Aug 2025 03:10:01 +0200, Thorsten Blum wrote:
> Commit 5304877936c0 ("NFSD: Fix strncpy() fortify warning") replaced
> strncpy(,, sizeof(..)) with strlcpy(,, sizeof(..) - 1), but strlcpy()
> already guaranteed NUL-termination of the destination buffer and
> subtracting one byte potentially truncated the source string.
> 
> The incorrect size was then carried over in commit 72f78ae00a8e ("NFSD:
> move from strlcpy with unused retval to strscpy") when switching from
> strlcpy() to strscpy().
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] NFSD: Fix destination buffer size in nfsd4_ssc_setup_dul()
      commit: 387d7905fb60d28ae3f2ff8956de626c797e4508

--
Chuck Lever