Re: [PATCH] mm/numa_memblks: Use pr_debug instead of printk(KERN_DEBUG)

[Joshua Hahn]

On Fri, 08 Aug 2025 17:42:22 +0530 pratyush.brahma@xxxxxxxxxxxxxxxx wrote:

> From: Pratyush Brahma <pratyush.brahma@xxxxxxxxxxxxxxxx>

Hi Pratyush,

Thank you for this patch!

> Replace the direct usage of printk(KERN_DEBUG ...) with pr_debug(...) to
> align with the consistent `pr_*` API usage within the file.

This change makes sense to me. Also, I think this patch gets rid of the last
caller of printk. Should we also remove the #include <linux/printk.h>?

With that change, please feel free to add my review tag. Have a great day!
Joshua

Reviewed-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>

> Signed-off-by: Pratyush Brahma <pratyush.brahma@xxxxxxxxxxxxxxxx>
> ---
>  mm/numa_memblks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
> index 541a99c4071a67e5b0ef66f4136dee268a880003..de626525a87c3ed54d31695e86f18c980c084558 100644
> --- a/mm/numa_memblks.c
> +++ b/mm/numa_memblks.c
> @@ -76,7 +76,7 @@ static int __init numa_alloc_distance(void)
>  		for (j = 0; j < cnt; j++)
>  			numa_distance[i * cnt + j] = i == j ?
>  				LOCAL_DISTANCE : REMOTE_DISTANCE;
> -	printk(KERN_DEBUG "NUMA: Initialized distance table, cnt=%d\n", cnt);
> +	pr_debug("NUMA: Initialized distance table, cnt=%d\n", cnt);
>  
>  	return 0;
>  }
> 
> ---
> base-commit: 479058002c32b77acac43e883b92174e22c4be2d
> change-id: 20250808-numa-dbg-62a8b2092c56
> 
> Best regards,
> -- 
> Pratyush Brahma <pratyush.brahma@xxxxxxxxxxxxxxxx>

Sent using hkml (https://github.com/sjp38/hackermail)