Re: [RFC PATCH 18/31] cifs: Pass smb_message structs down into the transport layer

[Enzo Matsumiya]

Hi David,

On 08/06, David Howells wrote:
> ...
>
> static int
> -receive_encrypted_read(struct TCP_Server_Info *server, struct smb_message **smb,
> +receive_encrypted_read(struct TCP_Server_Info *server, struct smb_message **mid,
> 		       int *num_mids)
> {
> +	WARN_ON_ONCE(1);
> +	return -ENOANO; // TODO
> +#if 0
> 	char *buf = server->smallbuf;
> 	struct smb2_transform_hdr *tr_hdr = (struct smb2_transform_hdr *)buf;
> 	struct iov_iter iter;
> @@ -4753,8 +4758,8 @@ receive_encrypted_read(struct TCP_Server_Info *server, struct smb_message **smb,
> 	dw->server = server;
>
> 	*num_mids = 1;
> -	len = min_t(unsigned int, buflen, server->vals->read_rsp_size +
> -		sizeof(struct smb2_transform_hdr)) - HEADER_SIZE(server) + 1;
> +	len = umin(buflen, server->vals->read_rsp_size +
> +		   sizeof(struct smb2_transform_hdr)) - HEADER_SIZE(server) + 1;
>
> 	rc = cifs_read_from_socket(server, buf + HEADER_SIZE(server) - 1, len);
> 	if (rc < 0)
> @@ -4836,6 +4841,7 @@ receive_encrypted_read(struct TCP_Server_Info *server, struct smb_message **smb,
> discard_data:
> 	cifs_discard_remaining_data(server);
> 	goto free_pages;
> +#endif
> }

I don't quite get why this was commented out (and also seems unrelated
to patch subject).

What problems did you have here?  Does it not work?