Re: [PATCH v3 1/2] fscontext: do not consume log entries when returning -EMSGSIZE

[Christian Brauner]

On Wed, Aug 06, 2025 at 08:07:51PM +0100, Al Viro wrote:
> On Thu, Aug 07, 2025 at 03:55:23AM +1000, Aleksa Sarai wrote:
> 
> > -		goto err_free;
> > -	ret = -EFAULT;
> > -	if (copy_to_user(_buf, p, n) != 0)
> > -		goto err_free;
> > +	if (copy_to_user(_buf, p, n))
> > +		n = -EFAULT;
> >  	ret = n;
> > -
> > -err_free:
> >  	if (need_free)
> >  		kfree(p);
> >  	return ret;
> 
> Minor nit: seeing that there's only one path to that return, I would
> rather turn it into
> 	return n;
> and dropped the assignment to ret a few lines above.  Anyway, that's
> trivially done when applying...
> 
> Anyway, who's carrying fscontext-related stuff this cycle?  I've got
> a short series in that area, but there won't be much from me around
> there - a plenty of tree-in-dcache stuff, quite a bit of mount-related
> work, etc., but not a lot around the options-parsing machinery.
> 
> Christian, do you have any plans around that area?

I've got a tree for that already and have applied related stuff there.
I've fixed up the comments from this thread.