Re: [PATCH v9 1/6] dt-bindings: mfd: add pf1550

[Sean Nyekjaer]

On Wed, Jul 16, 2025 at 11:11:44AM +0100, Samuel Kayode via B4 Relay wrote:
> From: Samuel Kayode <samuel.kayode@xxxxxxxxxxxxxxxxxxxx>
> 
> Add a DT binding document for pf1550 PMIC. This describes the core mfd
> device along with its children: regulators, charger and onkey.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Samuel Kayode <samuel.kayode@xxxxxxxxxxxxxxxxxxxx>
> ---
> v9:
>  - Add regulator suspend bindings in example
>  - Add binding for disabling onkey power down
>  - Fix thermal regulation temperature range
> v5:
>  - Address Krzystof's feedback:
>    - Drop monitored battery ref already included in power supply schema
>    - Move `additionalProperties` close to `type` for regulator
>    - Drop unneccessary |
>    - Change `additionalProperties` to `unevaluatedProperties` for the
>      PMIC
> v4:
>  - Address Krzystof's feedback:
>    - Filename changed to nxp,pf1550.yaml
>    - Replace Freescale with NXP
>    - Define include before battery-cell
>    - Drop operating-range-celsius in example since
>      nxp,thermal-regulation-celsisus already exists
>  - Not sure if there is similar binding to thermal-regulation...
>    for regulating temperature on thermal-zones? @Sebastian and @Krzysztof
> v3:
>  - Address Krzysztof's feedback:
>    - Fold charger and onkey objects
>    - Drop compatible for sub-devices: onkey, charger and regulator.
>    - Drop constant voltage property already included in
>      monitored-battery
>    - Fix whitespace warnings
>    - Fix license
> v2:
>  - Add yamls for the PMIC and the sub-devices
> ---
>  .../devicetree/bindings/mfd/nxp,pf1550.yaml        | 144 +++++++++++++++++++++
>  1 file changed, 144 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml b/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..ede5b6a2106ff60f4b47b3602fea8dd0b62d6fcf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/nxp,pf1550.yaml
> @@ -0,0 +1,144 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/nxp,pf1550.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PF1550 Power Management IC
> +
> +maintainers:
> +  - Samuel Kayode <samuel.kayode@xxxxxxxxxxxxxxxxxxxx>
> +
> +description:
> +  PF1550 PMIC provides battery charging and power supply for low power IoT and
> +  wearable applications. This device consists of an i2c controlled MFD that
> +  includes regulators, battery charging and an onkey/power button.
> +
> +$ref: /schemas/power/supply/power-supply.yaml
> +
> +properties:
> +  compatible:
> +    const: nxp,pf1550
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  wakeup-source: true
> +
> +  regulators:
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      "^(ldo[1-3]|sw[1-3]|vrefddr)$":
> +        type: object
> +        $ref: /schemas/regulator/regulator.yaml
> +        description:
> +          regulator configuration for ldo1-3, buck converters(sw1-3)
> +          and DDR termination reference voltage (vrefddr)
> +        unevaluatedProperties: false
> +
> +  monitored-battery:
> +    description: |
> +      A phandle to a monitored battery node that contains a valid value
> +      for:
> +      constant-charge-voltage-max-microvolt.
> +
> +  nxp,thermal-regulation-celsius:
> +    description:
> +      Temperature threshold for thermal regulation of charger in celsius.
> +    enum: [ 80, 95, 110, 125 ]
> +
> +  nxp,min-system-microvolt:
> +    description:
> +      System specific lower limit voltage.
> +    enum: [ 3500000, 3700000, 4300000 ]
> +
> +  nxp,disable-key-power:
> +    type: boolean
> +    description:
> +      Disable power-down using a long key-press. The onkey driver will remove
> +      support for the KEY_POWER key press when triggered using a long press of
> +      the onkey.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/input/linux-event-codes.h>
> +
> +    battery: battery-cell {
> +        compatible = "simple-battery";
> +        constant-charge-voltage-max-microvolt = <4400000>;
> +    };
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        pmic@8 {
> +            compatible = "nxp,pf1550";
> +            reg = <0x8>;
> +
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +            wakeup-source;
> +            monitored-battery = <&battery>;
> +            nxp,min-system-microvolt = <4300000>;
> +            nxp,thermal-regulation-celsius = <80>;
> +
> +            regulators {
> +                sw1_reg: sw1 {
> +                    regulator-name = "sw1";
> +                    regulator-min-microvolt = <600000>;
> +                    regulator-max-microvolt = <1387500>;
> +                    regulator-always-on;
> +                    regulator-ramp-delay = <6250>;
> +                };
> +
> +                sw2_reg: sw2 {
> +                    regulator-name = "sw2";
> +                    regulator-min-microvolt = <600000>;
> +                    regulator-max-microvolt = <1387500>;
> +                    regulator-always-on;
> +                };
> +
> +                sw3_reg: sw3 {
> +                    regulator-name = "sw3";
> +                    regulator-min-microvolt = <1800000>;
> +                    regulator-max-microvolt = <3300000>;
> +                    regulator-always-on;
> +                };
> +
> +                vldo1_reg: ldo1 {
> +                    regulator-name = "ldo1";
> +                    regulator-min-microvolt = <750000>;
> +                    regulator-max-microvolt = <3300000>;
> +                    regulator-always-on;
> +                };
> +
> +                vldo2_reg: ldo2 {
> +                    regulator-name = "ldo2";
> +                    regulator-min-microvolt = <1800000>;
> +                    regulator-max-microvolt = <3300000>;
> +                    regulator-always-on;
> +                };
> +
> +                vldo3_reg: ldo3 {
> +                    regulator-name = "ldo3";
> +                    regulator-min-microvolt = <750000>;
> +                    regulator-max-microvolt = <3300000>;
> +                    regulator-always-on;
> +                };
> +            };
> +        };
> +    };
> 
> --
> 2.50.1
> 
> 

Does it make sense to show that the driver support suspend to mem
states? Like...


			sw1_reg: sw1 {
				regulator-name = "sw1";
				regulator-min-microvolt = <1325000>;
				regulator-max-microvolt = <1325000>;
				regulator-always-on;

				regulator-state-mem {
					regulator-on-in-suspend;
					regulator-suspend-max-microvolt = <900000>;
					regulator-suspend-min-microvolt = <900000>;
				};
			};

			sw2_reg: sw2 {
				regulator-name = "sw2";
				regulator-min-microvolt = <1350000>;
				regulator-max-microvolt = <1350000>;
				regulator-always-on;

				regulator-state-mem {
					regulator-on-in-suspend;
				};
			};

			sw3_reg: sw3 {
				regulator-name = "sw3";
				regulator-min-microvolt = <3300000>;
				regulator-max-microvolt = <3300000>;
				regulator-always-on;

				regulator-state-mem {
					regulator-on-in-suspend;
				};
			};

			vldo1_reg: ldo1 {
				regulator-name = "ldo1";
				regulator-min-microvolt = <2900000>;
				regulator-max-microvolt = <2900000>;
				regulator-always-on;

				regulator-state-mem {
					regulator-off-in-suspend;
				};
			};

Br,
Sean