Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add lemans-evk and monaco-evk sound card

[Krzysztof Kozlowski]

On 08/08/2025 07:29, Mohammad Rafi Shaik wrote:
> Document the bindings for the Qualcomm LEMANS-EVK and MONACO-EVK
> board specific sound card.
> 
> The bindings are the same as for other newer Qualcomm ADSP sound cards,
> thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
> is separate.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index 5d3dbb6cb1ae..c63bfe031b57 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -31,6 +31,8 @@ properties:
>            - fairphone,fp4-sndcard
>            - fairphone,fp5-sndcard
>            - qcom,apq8096-sndcard
> +          - qcom,lemans-evk-sndcard


Lemans is already there under one of the QCS cards. I was told it is the
same, so you do not get a new compatible.

Monaco maybe as well.

We also name standard cards per SoC, not per board, so evk should be
dropped or commit msg should explain why this is different.


Best regards,
Krzysztof