Re: [PATCH v2 3/3] dmaengine: lgm-dma: Added Software management functions on HDMA.

[Krzysztof Kozlowski]

On 08/08/2025 05:22, Zhu Yixin wrote:
> +
> +struct dw4_desc_sw {
> +	struct virt_dma_desc	vd;
> +	struct ldma_chan	*chan;
> +	struct dw4_desc_hw	*desc_hw;
> +};
> +
> +/**
> + * hdma TX need some sideband info to switch in dw0 and dw1

That's not a kerneldoc.

Please run standard kernel tools for static analysis, like coccinelle,
smatch and sparse, and fix reported warnings. Also please check for
warnings when building with W=1. Most of these commands (checks or W=1
build) can build specific targets, like some directory, to narrow the
scope to only your code. The code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.


Best regards,
Krzysztof