Re: [f2fs-dev] [PATCH] f2fs: fix to clear unusable_cap for checkpoint=enable

[Chao Yu]

On 8/8/2025 9:07 AM, Zhiguo Niu wrote:
> Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx>
> 于2025年8月7日周四 09:52写道：
> > mount -t f2fs -o checkpoint=disable:10% /dev/vdb /mnt/f2fs/
> > mount -t f2fs -o remount,checkpoint=enable /dev/vdb /mnt/f2fs/
> >
> > kernel log:
> > F2FS-fs (vdb): Adjust unusable cap for checkpoint=disable = 204440 / 10%
> >
> > If we has assigned checkpoint=enable mount option, unusable_cap{,_perc}
> > parameters of checkpoint=disable should be reset, then calculation and
> > log print could be avoid in adjust_unusable_cap_perc().
> >
> > Fixes: 1ae18f71cb52 ("f2fs: fix checkpoint=disable:%u%%")
> > Signed-off-by: Chao Yu <chao@xxxxxxxxxx>
> > ---
> >   fs/f2fs/super.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index f37004780ce0..c1f45df9efec 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1014,6 +1014,10 @@ static int f2fs_parse_param(struct fs_context *fc, struct fs_parameter *param)
> >                          ctx_set_opt(ctx, F2FS_MOUNT_DISABLE_CHECKPOINT);
> >                          break;
> >                  case Opt_checkpoint_enable:
> > +                       F2FS_CTX_INFO(ctx).unusable_cap_perc = 0;
> > +                       ctx->spec_mask |= F2FS_SPEC_checkpoint_disable_cap_perc;
> > +                       F2FS_CTX_INFO(ctx).unusable_cap = 0;
> > +                       ctx->spec_mask |= F2FS_SPEC_checkpoint_disable_cap;
> Hi Chao,
> when enable checkpoint, shoud it be:
> ctx->spec_mask &= ~F2FS_SPEC_checkpoint_disable_cap_perc;
> ctx->spec_mask &= ~F2FS_SPEC_checkpoint_disable_cap;
> please correct me if I misunderstanding.

Zhiguo,

IMO, F2FS_SPEC_checkpoint_disable_cap_perc or F2FS_SPEC_checkpoint_disable_cap
flags can be added to ctx->spec_mask to indicate ctx.unusable_cap_perc or
ctx.unusable_cap has been updated, then we can store last parameter value from
ctx to sbi in f2fs_apply_options() as below:

	if (ctx->spec_mask & F2FS_SPEC_checkpoint_disable_cap)
		F2FS_OPTION(sbi).unusable_cap = F2FS_CTX_INFO(ctx).unusable_cap;
	if (ctx->spec_mask & F2FS_SPEC_checkpoint_disable_cap_perc)
		F2FS_OPTION(sbi).unusable_cap_perc =
					F2FS_CTX_INFO(ctx).unusable_cap_perc;

Or am I missing something here?

Thanks,

> thanks!
> >                          ctx_clear_opt(ctx, F2FS_MOUNT_DISABLE_CHECKPOINT);
> >                          break;
> >                  default:
> > --
> > 2.49.0
> >
> >
> >
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel