RE: [Intel-wired-lan] [RFC PATCH] net: add net-device TX clock source selection framework

From: Kubalewski, Arkadiusz
Date: Thu Jul 31 2025 - 16:36:54 EST


>From: Ivan Vecera <ivecera@xxxxxxxxxx>
>Sent: Wednesday, July 30, 2025 4:45 PM
>
>On 30. 07. 25 2:26 odp., Jiri Pirko wrote:
>> Tue, Jul 29, 2025 at 12:45:28PM +0200, arkadiusz.kubalewski@xxxxxxxxx
>wrote:
>>
>> [...]
>>
>>> User interface:
>>> - Read /sys/class/net/<device>/tx_clk/<clock_name> to get status
>>> (0/1)
>>> - Write "1" to switch to that clock source
>>
>> I wonder, if someone invented a time machine and sent me back to 2005...
>>
>> [...]
>>
>+1
>why do we have netlink based interfaces for configuration...?
>
>Wouldn't be better to implement such thing to be configurable via ip link
>or ethtool??
>
>E.g.
>ip link set eth0 tx-clk <clock_name>
>
>--or--
>ethtool --set-tx-clk/--show-tx-clk eth0 <clock_name>
>
>Ivan
>

Hmm, sounds for me, looks clean and easy to understand.

Thank you!
Arkadiusz