Re: [PATCH] memory: samsung: exynos-srom: Fix of_iomap leak in exynos_srom_probe

[Krzysztof Kozlowski]

On 31/07/2025 11:40, zhen.ni wrote:
> Hi,
> 
> During static analysis with Smatch, I identified the following issue:
> 
> ```
> drivers/memory/samsung/exynos-srom.c:155 exynos_srom_probe()
> warn: 'srom->reg_base' from of_iomap() not released on lines: 155.

Nothing in commit msg explained you used Smatch. You must describe the
tools you use.

> ```
> 
> Problem analysis:
> 1. In exynos_srom_probe(), the reg_base resource is acquired via of_iomap()
> 2. The of_platform_populate() call at the end of the function has a 
> possible failure path:

Above is AI/LLM output?

> ```
> root = root ? of_node_get(root) : of_find_node_by_path("/");
> if (!root)
>       return -EINVAL; // Failure return point
> ```
> 3. When this path is taken, reg_base is not released, causing a resource 
> leak
> 
> Verification:
> After applying the patch, the Smatch warning is resolved

This means no testing. You should mention it as well.

Don't top post. See netiquette.


Best regards,
Krzysztof