Re: [PATCH v2 6/9] thermal/drivers/mediatek/lvts: Add support for ATP mode

[Laura Nao]

Hi Fei,

On 7/31/25 06:25, Fei Shao wrote:
> On Wed, Jul 30, 2025 at 11:40 PM Laura Nao <laura.nao@xxxxxxxxxxxxx> wrote:
>>
>> MT8196/MT6991 uses ATP (Abnormal Temperature Prevention) mode to detect
>> abnormal temperature conditions, which involves reading temperature data
>> from a dedicated set of registers separate from the ones used for
>> immediate and filtered modes.
>>
>> Add support for ATP mode and its relative registers to ensure accurate
>> temperature readings and proper thermal management on MT8196/MT6991
>> devices.
>>
>> While at it, convert mode defines to enum.
>>
>> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
>> Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>
>
> It's not visible in this patch, but a heads-up that I see
> lvts_ctrl_start() also depends on whether lvts is in immediate mode. I
> wonder if anything is needed there for ATP mode e.g. a new
> sensor_atp_bitmap.
> Feel free to ignore if this is a false alarm.
>

Thanks for the heads up - the bitmap for ATP mode is the same as 
sensor_filt_bitmap, so the function is already working as intended.

Best,

Laura

> Regards,
> Fei