Re: [PATCH v17 12/24] KVM: x86/mmu: Rename .private_max_mapping_level() to .gmem_max_mapping_level()
From: Fuad Tabba
Date: Thu Jul 31 2025 - 04:34:33 EST
On Thu, 31 Jul 2025 at 09:29, David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> On 31.07.25 10:15, Fuad Tabba wrote:
> > On Tue, 29 Jul 2025 at 23:55, Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> >>
> >> From: Ackerley Tng <ackerleytng@xxxxxxxxxx>
> >>
> >> Rename kvm_x86_ops.private_max_mapping_level() to .gmem_max_mapping_level()
> >> in anticipation of extending guest_memfd support to non-private memory.
> >>
> >> No functional change intended.
> >>
> >> Reviewed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
> >> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
> >> Signed-off-by: Ackerley Tng <ackerleytng@xxxxxxxxxx>
> >> Signed-off-by: Fuad Tabba <tabba@xxxxxxxxxx>
> >> Co-developed-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> >> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> >> ---
> >
> > nit: remove my "Signed-off-by", since I'm not a co-developer, and instead:
>
> The patch went "through your hands", right? In that case, a SOB is the
> right thing to do.
>
> "The Signed-off-by: tag indicates that the signer was involved in the
> development of the patch, or that he/she was in the patch's delivery path."
I see. I thought it only applied to the current re-spin.
In that case, sorry for the noise! :)
Cheers,
/fuad
> --
> Cheers,
>
> David / dhildenb
>