Re: [PATCH V1 2/3] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller

[Krzysztof Kozlowski]

On 30/07/2025 10:22, Ram Kumar Dwivedi wrote:
> Enable Multi-Circular Queue (MCQ) support for the UFS host controller
> on the Qualcomm SM8650 platform by updating the device tree node. This
> includes adding new register regions and specifying the MSI parent
> required for MCQ operation.
> 
> MCQ is a modern queuing model for UFS that improves performance and
> scalability by allowing multiple hardware queues. 
> 
> Changes:
> - Add reg entries for mcq_sqd and mcq_vs regions.
> - Define reg-names for the new regions.
> - Specify msi-parent for interrupt routing.
> 
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index e14d3d778b71..5d164fe511ba 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -3982,7 +3982,12 @@ ufs_mem_phy: phy@1d80000 {
>  
>  		ufs_mem_hc: ufshc@1d84000 {
>  			compatible = "qcom,sm8650-ufshc", "qcom,ufshc", "jedec,ufs-2.0";
> -			reg = <0 0x01d84000 0 0x3000>;
> +			reg = <0 0x01d84000 0 0x3000>,
> +			      <0 0x01da5000 0 0x2000>,
> +			      <0 0x01da4000 0 0x0010>;


These are wrong address spaces. Open your datasheet and look there.


Best regards,
Krzysztof