Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor

From: Krzysztof Kozlowski
Date: Thu Jul 31 2025 - 02:39:59 EST


On 31/07/2025 08:36, Hardevsinh Palaniya wrote:
>> On 31/07/2025 08:09, Hardevsinh Palaniya wrote:
>>> +        properties:
>>> +          data-lanes:
>>> +            items:
>>> +              - const: 1
>>> +              - const: 2
>>> +          link-frequencies: true
>> Nothing improved. My comments from versions before still apply.
>
> I asked you in v4, but you didn’t respond.
>
> Could you please check?
>
> Link:https://lore.kernel.org/linux-media/PN3P287MB351999B4DB533CCA9C6E6567FF51A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>
> The driver will always rely on the device tree for the link frequency.
> Without it, the driver will fail to probe.

How is it related? I did not ask to remove it from the driver.

>
> So, the bindings need this property, just like other camera sensors do.
The property is already there, you just duplicated it. You added
completely redundant code and instead of ACTUALLY TESTING YOUR DTS you
keep disagreeing.

So test your DTS first.

Best regards,
Krzysztof