Re: [PATCH v2 3/3] md: Fix the return value of mddev_stack_new_rdev

[Martin K. Petersen]

> In mddev_stack_new_rdev(), if the integrity profile check fails, it
> returns -ENXIO, which means "No such device or address". This is
> inaccurate and can mislead users. Change it to return -EINVAL.

> Fixes: c6e56cf6b2e7 ("block: move integrity information into queue_limits")

Returning -ENXIO predates the above commit by many, many years. Changing
the return value might break applications which rely on the original
behavior.

In case of a stacking failure, an appropriate message is logged and the
function returns an errno. How is that misleading?

-- 
Martin K. Petersen