Re: [PATCH 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate()

From: Brian Masney
Date: Wed Jul 30 2025 - 17:45:18 EST


On Fri, Jul 11, 2025 at 3:05 AM Maxime Ripard <mripard@xxxxxxxxxx> wrote:
> On Thu, Jul 10, 2025 at 01:43:10PM -0400, Brian Masney wrote:
> > -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate,
> > - unsigned long *parent_rate)
> > +static int sun4i_dclk_determine_rate(struct clk_hw *hw,
> > + struct clk_rate_request *req)
> > {
> > struct sun4i_dclk *dclk = hw_to_dclk(hw);
> > struct sun4i_tcon *tcon = dclk->tcon;
> > @@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate,
> > int i;
> >
> > for (i = tcon->dclk_min_div; i <= tcon->dclk_max_div; i++) {
> > - u64 ideal = (u64)rate * i;
> > + u64 ideal = (u64) req->rate * i;
>
> There shouldn't be any space after the cast.
>
> Once fixed,
> Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>

OK. I'm planning to submit a v2 of this series on August 11th when
v6.17rc1 is out. Unless the maintainer that picks up this whole series
plans to drop the space on merge.

Brian