Re: [PATCH v16 28/34] fs/resctrl: Auto assign counters on mkdir and clean up on group removal

[Reinette Chatre]

Hi Babu,

On 7/25/25 11:29 AM, Babu Moger wrote:

> ---
>  fs/resctrl/monitor.c  |  1 +
>  fs/resctrl/rdtgroup.c | 70 +++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 69 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/resctrl/monitor.c b/fs/resctrl/monitor.c
> index 6205bbfe08fb..5cf1b79c17f5 100644
> --- a/fs/resctrl/monitor.c
> +++ b/fs/resctrl/monitor.c
> @@ -1072,6 +1072,7 @@ int resctrl_mon_resource_init(void)
>  		mon_event_all[QOS_L3_MBM_LOCAL_EVENT_ID].evt_cfg = READS_TO_LOCAL_MEM |
>  								   READS_TO_LOCAL_S_MEM |
>  								   NON_TEMP_WRITE_TO_LOCAL_MEM;
> +		r->mon.mbm_assign_on_mkdir = true;
>  		resctrl_file_fflags_init("num_mbm_cntrs",
>  					 RFTYPE_MON_INFO | RFTYPE_RES_CACHE);
>  		resctrl_file_fflags_init("available_mbm_cntrs",
> diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
> index bf04235d2603..d087ba990cd3 100644
> --- a/fs/resctrl/rdtgroup.c
> +++ b/fs/resctrl/rdtgroup.c

Please move rdtgroup_assign_cntrs() and rdtgroup_unassign_cntrs() to
be with counter management code in monitor.c

Reinette