Re: [PATCH v2 2/5] mq-deadline: switch to use elevator lock

From: Yu Kuai
Date: Wed Jul 30 2025 - 14:02:55 EST


Hi,

在 2025/7/31 1:21, Bart Van Assche 写道:
On 7/30/25 1:22 AM, Yu Kuai wrote:
@@ -466,10 +466,9 @@ static struct request *dd_dispatch_request(struct blk_mq_hw_ctx *hctx)
      struct request *rq;
      enum dd_prio prio;
  -    spin_lock(&dd->lock);
      rq = dd_dispatch_prio_aged_requests(dd, now);

The description says "no functional changes" but I think I see a functional change above. Please restrict this patch to changing
&dd->lock into dd->lock only.
Ok, you mean that the lock is moved to the caller is functional change, right?

Thanks,
Kuai

Thanks,

Bart.