Re: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support for SD_BUF0 in polling mode

[Geert Uytterhoeven]

Hi Wolfram,

On Wed, 30 Jul 2025 at 11:17, Wolfram Sang <wsa-dev@xxxxxxxxxxxxxxxxxxxx> wrote:
> >    In file included from drivers/mmc/host/uniphier-sd.c:21:
> > >> drivers/mmc/host/tmio_mmc.h:249:2: error: call to undeclared function 'ioread64_rep'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >      249 |         ioread64_rep(host->ctl + (addr << host->bus_shift), buf, count);
> >          |         ^
> > >> drivers/mmc/host/tmio_mmc.h:255:2: error: call to undeclared function 'iowrite64_rep'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >      255 |         iowrite64_rep(host->ctl + (addr << host->bus_shift), buf, count);
> >          |         ^
>
> Sigh, then the guard seems to be ARM64 after all :(

ioread64_rep() is defined in include/asm-generic/io.h, and powerpc does
include that.

Perhaps drivers/mmc/host/tmio_mmc.h should just include <linux/io.h>?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds