RE: [PATCH] iio: xilinx-ams: Unmask interrupts after updating alarms

[Erim, Salih]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi,

I am really busy right now. I will look into this within next week.

Regards,
Salih.

> -----Original Message-----
> From: Simek, Michal <michal.simek@xxxxxxx>
> Sent: Monday, July 28, 2025 6:55 AM
> To: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Sean Anderson <sean.anderson@xxxxxxxxx>; Erim, Salih
> <Salih.Erim@xxxxxxx>; O'Griofa, Conall <conall.ogriofa@xxxxxxx>; Anand
> Ashok Dumbre <anand.ashok.dumbre@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
> David Lechner <dlechner@xxxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx; Andy Shevchenko <andy@xxxxxxxxxx>; Manish
> Narani <manish.narani@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] iio: xilinx-ams: Unmask interrupts after updating alarms
>
>
>
> On 7/27/25 17:43, Jonathan Cameron wrote:
> > On Fri, 25 Jul 2025 06:47:16 +0200
> > Michal Simek <michal.simek@xxxxxxx> wrote:
> >
> >> On 7/24/25 17:32, Jonathan Cameron wrote:
> >>> On Mon, 14 Jul 2025 20:28:47 -0400
> >>> Sean Anderson <sean.anderson@xxxxxxxxx> wrote:
> >>>
> >>>> To convert level-triggered alarms into edge-triggered IIO events,
> >>>> alarms are masked when they are triggered. To ensure we catch
> >>>> subsequent alarms, we then periodically poll to see if the alarm is still active.
> >>>> If it isn't, we unmask it. Active but masked alarms are stored in
> >>>> current_masked_alarm.
> >>>>
> >>>> If an active alarm is disabled, it will remain set in
> >>>> current_masked_alarm until ams_unmask_worker clears it. If the
> >>>> alarm is re-enabled before ams_unmask_worker runs, then it will
> >>>> never be cleared from current_masked_alarm. This will prevent the
> >>>> alarm event from being pushed even if the alarm is still active.
> >>>>
> >>>> Fix this by recalculating current_masked_alarm immediately when
> >>>> enabling or disabling alarms.
> >>>>
> >>>> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> >>>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>
> >>>> ---
> >>> Anand?
> >>>
> >>> This seems fine to me, but I'm not that familiar with the hardware or driver.
> >>
> >> Anand left some time ago. Salih or Conall should be able to provide some input.
> >>
> >> Thanks,
> >> Michal
> >>
> >
> > Hi Michal,
> >
> > Thanks for letting me know.  Would be good to have a MAINTAINERS
> > update patch to remove Anand + ideally add someone else.  If not to
> > mark it orphaned (will still be covered by the top level IIO entry).
>
> Salih: Can you please send a patch for it?
>
> It is also covered my fragment that's why you don't need to explicitly add me there.
>
> Thanks,
> Michal
>
>