[PATCH v2] usb: gadget: uvc: avoid assignment in if conditions

From: Darshan Rathod
Date: Wed Jul 30 2025 - 06:17:59 EST


Refactored code to separate assignments from conditional checks.
This improves readability and conforms to kernel coding style
as reported by checkpatch.pl.

Signed-off-by: Darshan Rathod <darshanrathod475@xxxxxxxxx>
---
drivers/usb/gadget/function/uvc_video.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index fb77b0b21790..d77ee5fd9b21 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -777,18 +777,21 @@ int uvcg_video_enable(struct uvc_video *video)
*/
video->is_enabled = true;

- if ((ret = uvcg_queue_enable(&video->queue, 1)) < 0)
+ ret = uvcg_queue_enable(&video->queue, 1);
+ if (ret < 0)
return ret;

- if ((ret = uvc_video_alloc_requests(video)) < 0)
+ ret = uvc_video_alloc_requests(video);
+ if (ret < 0)
return ret;

if (video->max_payload_size) {
video->encode = uvc_video_encode_bulk;
video->payload_size = 0;
- } else
+ } else {
video->encode = video->queue.use_sg ?
uvc_video_encode_isoc_sg : uvc_video_encode_isoc;
+ }

video->req_int_count = 0;

--
2.43.0