Re: [PATCH v2 1/2] dt-bindings: usb: Add Eswin EIC7700 USB controller

[Krzysztof Kozlowski]

On 30/07/2025 09:40, zhangsenchuan@xxxxxxxxxxxxxxxxxx wrote:
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;

This wasn't here. Drop.

> +
> +        usb {
> +            compatible = "eswin,eic7700-dwc3";
> +            clocks = <&fixed_factor_u_clk_1m_div24>,
> +                     <&gate_clk_hsp_aclk>,
> +                     <&gate_clk_hsp_cfgclk>;
> +            clock-names = "suspend","aclk", "cfg";
> +            eswin,hsp-sp-csr = <&hsp_sp_csr 0x800 0x808 0x83c 0x840>;
> +            resets = <&reset 84>;
> +            reset-names = "vaux";
> +            ranges;

Same comment: follow DTS coding style. Where should ranges or reg be placed?

> +            #address-cells = <2>;
> +            #size-cells = <2>;
> +
> +            usb@50480000 {
> +                compatible = "snps,dwc3";
> +                reg = <0x0 0x50480000 0x0 0x10000>;

Nothing improved and you did not respond to the feedback.


Best regards,
Krzysztof