Re: [PATCH v7 3/3] riscv: dts: canaan: Add clock definition for K230

[Krzysztof Kozlowski]

On Wed, Jul 30, 2025 at 02:43:53AM +0800, Xukai Wang wrote:
> This patch describes the clock controller integrated in K230 SoC
> and replace dummy clocks with the real ones for UARTs.
> 
> For k230-canmv and k230-evb, they provide an additional external
> pulse input through a pin to serve as clock source.
> 
> Co-developed-by: Troy Mitchell <TroyMitchell988@xxxxxxxxx>
> Signed-off-by: Troy Mitchell <TroyMitchell988@xxxxxxxxx>
> Signed-off-by: Xukai Wang <kingxukai@xxxxxxxxxxxx>
> ---
>  arch/riscv/boot/dts/canaan/k230-canmv.dts | 11 +++++++++++
>  arch/riscv/boot/dts/canaan/k230-evb.dts   | 11 +++++++++++
>  arch/riscv/boot/dts/canaan/k230.dtsi      | 26 ++++++++++++++++++--------
>  3 files changed, 40 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/canaan/k230-canmv.dts b/arch/riscv/boot/dts/canaan/k230-canmv.dts
> index 9565915cead6ad2381ea8249b616e79575feb896..6579d39e2c1690d9e9c2b9c884db528c37473204 100644
> --- a/arch/riscv/boot/dts/canaan/k230-canmv.dts
> +++ b/arch/riscv/boot/dts/canaan/k230-canmv.dts
> @@ -17,8 +17,19 @@ ddr: memory@0 {
>  		device_type = "memory";
>  		reg = <0x0 0x0 0x0 0x20000000>;
>  	};
> +
> +	timerx_pulse_in: timer_pulse_in {

Follow DTS coding style.

Please use name for all fixed clocks which matches current format
recommendation: 'clock-<freq>' (see also the pattern in the binding for
any other options).
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml?h=v6.11-rc1

Best regards,
Krzysztof