[PATCH 1/2] cpufreq: CPPC: Don't warn on failing to read perf counters on offline cpus
From: Bowen Yu
Date: Tue Jul 29 2025 - 23:23:51 EST
From: Jie Zhan <zhanjie9@xxxxxxxxxxxxx>
Reading perf counters on offline cpus should be expected to fail, e.g. it
returns -EFAULT as counters are shown to be 0. Remove the unnecessary
warning print on this failure path.
Signed-off-by: Jie Zhan <zhanjie9@xxxxxxxxxxxxx>
Signed-off-by: Bowen Yu <yubowen8@xxxxxxxxxx> # Changing loglevel to debug
---
drivers/cpufreq/cppc_cpufreq.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index a1fd0ff22bc5..904006027df2 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -144,16 +144,14 @@ static void cppc_cpufreq_cpu_fie_init(struct cpufreq_policy *policy)
init_irq_work(&cppc_fi->irq_work, cppc_irq_work);
ret = cppc_get_perf_ctrs(cpu, &cppc_fi->prev_perf_fb_ctrs);
- if (ret) {
- pr_warn("%s: failed to read perf counters for cpu:%d: %d\n",
- __func__, cpu, ret);
-
+ if (ret && cpu_online(cpu)) {
/*
* Don't abort if the CPU was offline while the driver
* was getting registered.
*/
- if (cpu_online(cpu))
- return;
+ pr_debug("%s: failed to read perf counters for cpu:%d: %d\n",
+ __func__, cpu, ret);
+ return;
}
}
--
2.33.0