Re: [PATCH v3 4/5] arm64: dts: rockchip: Add missing dp_out port for RK3399 CDN-DP

[Chaoyi Chen]

On 7/30/2025 3:59 AM, Diederik de Haas wrote:

> On Tue Jul 29, 2025 at 11:00 AM CEST, Chaoyi Chen wrote:
> > From: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
> >
> > Let's make the ports nodes of cdn_dp in the same style as the other
> > display interface, and match the style of ports's yaml.
> >
> > Signed-off-by: Chaoyi Chen <chaoyi.chen@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 12 +++++++++++-
> >   1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> > index 9d5f5b083e3c..edeb177bc433 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> > @@ -618,7 +618,11 @@ cdn_dp: dp@fec00000 {
> >   		status = "disabled";
> >   
> >   		ports {
> > -			dp_in: port {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			dp_in: port@0 {
> > +				reg = <0>;
> >   				#address-cells = <1>;
> >   				#size-cells = <0>;
> >   
> > @@ -632,6 +636,12 @@ dp_in_vopl: endpoint@1 {
> >   					remote-endpoint = <&vopl_out_dp>;
> >   				};
> >   			};
> > +
> > +			dp_out: port@1 {
> > +				reg = <1>;
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +			};
> Patch 5 adds a single endpoint to dp_out (without a reg property), so it
> seems that #address/#size-cells is not needed?
> If you run ``make CHECK_DTBS=y W=1 rockchip/rk3399-evb-ind.dtb`` it
> should spit out a warning about that.
Exactly! Will remove this in v4.
> Cheers,
>    Diederik
>
> >   		};
> >   	};
> >