Re: [PATCH 1/3] dt-bindings: power: supply: Add Richtek RT9756 smart cap divider charger

From: Krzysztof Kozlowski
Date: Tue Jul 29 2025 - 11:41:25 EST


On 29/07/2025 06:21, cy_huang@xxxxxxxxxxx wrote:
> +
> + shunt-resistor-micro-ohms:
> + description: Battery current sense resistor mounted.
> + default: 2000
> +
> +required:
> + - compatible
> + - reg
> + - wakeup-source

Why do you require this? I cannot find any use of it, so maybe I missed
some change in Linux code (and that's second question like that for
Richtek, so refer to your other patchsets for contexr).

> + - interrupts
> +

Missing ref to power supply.

> +additionalProperties: false
> +

unevaluated instead


Best regards,
Krzysztof