Re: [PATCH] jfs: fix metapage reference count leak in dbAllocCtl

[Markus Elfring]

…
> +++ b/fs/jfs/jfs_dmap.c
> @@ -1809,8 +1809,10 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results)
>  			return -EIO;
>  		dp = (struct dmap *) mp->data;
>  
> -		if (dp->tree.budmin < 0)
> +		if (dp->tree.budmin < 0) {
> +			release_metapage(mp);
>  			return -EIO;
> +		}
…

Would it be a bit nicer to use an additional label for this case?

			rc = -EIO;
			goto release_metapage;


Regards,
Markus