Re: [PATCH v2] checkpatch: suppress strscpy warnings for userspace tools

[Suchit Karunakaran]

On Tue, 29 Jul 2025 at 15:54, Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Sun, 2025-07-27 at 18:20 +0530, Suchit Karunakaran wrote:
> > The checkpatch.pl script currently warns against the use of strcpy,
> > strlcpy, and strncpy, recommending strscpy as a safer alternative.
> > However, these warnings are also triggered for code under tools/ and
> > scripts/, which are userspace utilities where strscpy is not available.
> > This patch suppresses these warnings for files in tools/ and scripts/.
> >
> > Signed-off-by: Suchit Karunakaran <suchitkarunakaran@xxxxxxxxx>
> >
> > Changes since v1:
> > - Create is_userspace function to check if the file is in userspace
> >   directories
>
> the changelog bit should go below the --- line
>
> > ---
>
> This

Sorry I will change it in the next version.

> >  scripts/checkpatch.pl | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -7019,20 +7019,24 @@ sub process {
> >  #                    }
> >  #            }
> >
> > +        sub is_userspace {
> > +            my ($file) = @_;
> > +            return ($file =~ m@\btools/@ || $file =~ m@\bscripts/@);
>
> All other sub uses start in without indentation.
> Please move this next to other sub blocks.
>

Yup will do it.

> Please do a git ls-files -- '*tools/' and see if too many other
> files are matched, especially the Documentation/ ones.
>

I didn't quite understand this. Could you please elaborate?