Re: [PATCH v3 7/7] clk: qcom: gcc: Add support for Global Clock Controller

[Konrad Dybcio]

On 7/29/25 12:48 PM, Dmitry Baryshkov wrote:
> On Tue, Jul 29, 2025 at 11:12:41AM +0530, Taniya Das wrote:
>> Add support for Global clock controller for Glymur platform.
>>
>> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
>> ---
>>  drivers/clk/qcom/Kconfig      |    9 +
>>  drivers/clk/qcom/Makefile     |    1 +
>>  drivers/clk/qcom/gcc-glymur.c | 8623 +++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 8633 insertions(+)
>>
>> +static void clk_glymur_regs_configure(struct device *dev, struct regmap *regmap)
>> +{
>> +	int ret;
>> +
>> +	ret = qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks,
>> +				       ARRAY_SIZE(gcc_dfs_clocks));
> 
> Why are you doing this manually instead of using
> qcom_cc_driver_data.dfs_rcgs ?

I guess that has been merged last week or so, so yeah, please rebase

Konrad