Re: [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias

[Geert Uytterhoeven]

Hi Johan,

On Tue, 29 Jul 2025 at 11:23, Johan Hovold <johan@xxxxxxxxxx> wrote:
> On Mon, Jul 28, 2025 at 10:56:18AM +0200, Geert Uytterhoeven wrote:
> > On Thu, 24 Jul 2025 at 11:21, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > > Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car
> > > H3 ES1.* handling") the driver only supports OF probe so drop the unused
> > > platform module alias.
> > >
> > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> >
> > While I don't debate the actual change, I would like to comment on
> > the patch description.  The driver only ever supported OF probe.
> > The call to soc_device_match() was just used to override the match
> > data for quirk handling.
>
> The driver initially indeed only supported OF probe, but that changed
> with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use
> of_device_get_match_data() helper") after which the driver could at
> least theoretically also bind based on the platform device name.

Oh right, now I see what you meant.
Yes, in theory the driver could bind before on a legacy platform device,
but it would crash on a NULL-pointer dereference when running on
anything but R-Car H3 ES1.0x ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds