Re: [PATCH v3 09/14] drm/bridge: analogix_dp: Add support to find panel or bridge

[Damon Ding]

Hi Dmitry,

On 2025/7/26 20:03, Dmitry Baryshkov wrote:
> On Thu, Jul 24, 2025 at 04:02:59PM +0800, Damon Ding wrote:
> > Since the panel/bridge should logically be positioned behind the
> > Analogix bridge in the display pipeline, it makes sense to handle
> > the panel/bridge parsing on the Analogix side.
> >
> > Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx>
> > ---
> >   .../drm/bridge/analogix/analogix_dp_core.c    | 48 +++++++++++++++++++
> >   include/drm/bridge/analogix_dp.h              |  2 +
> >   2 files changed, 50 insertions(+)
> >
> > +int analogix_dp_find_panel_or_bridge(struct analogix_dp_device *dp)
>
> Nit: the API does more than just finding the panel or bridge. Also the
> drivers use it in a more of 'analogix_dp_finish_probe()' manner.
>
> >

Yes, since the new API also includes component_add(), it would be better 
to rename it.

And the commit message will be expanded in the next version.

Best regards,
Damon