Re: [PATCH net v2] net: atlantic: fix overwritten return value in Aquantia driver

From: Andrew Lunn
Date: Mon Jul 28 2025 - 21:39:42 EST


> This patch uses `err |=` instead of assignment, so that any earlier error
> is preserved even if later calls succeed. This is safe because all involved
> functions return standard negative error codes (e.g. -EIO, -ETIMEDOUT, etc).
> OR-ing such values does not convert them into success, and preserves the
> indication that an error occurred.

22 | 110 = 132 = ERFKILL

How easy will it be for somebody to debug that?

Andrew