Re: [PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

[Andy Shevchenko]

On Mon, Jul 28, 2025 at 9:27 AM Darshan R.
<rathod.darshan.0896@xxxxxxxxx> wrote:
>
> Updated the formatting of function definitions and if statements to match
> kernel coding standards. This helps with readability and consistency across
> the codebase.
>
> These are non-functional changes aimed at preparing the driver for eventual
> mainline readiness by addressing common checkpatch warnings.

...

>  void
>  ia_css_output_encode(

And what is about the above?

> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +       struct sh_css_isp_output_params *to,
> +       const struct ia_css_output_config *from,
> +       unsigned int size)

...

>  int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,

Seems too much space between _config and *to.

> -                         const struct ia_css_output1_configuration *from,
> +                         const struct ia_css_output1_configuration *from,
>                           unsigned int size)

...

>  int ia_css_output0_configure(const struct ia_css_binary    *binary,

Ditto.

> -                           const struct ia_css_frame_info *info)
> +                            const struct ia_css_frame_info *info)

...

The rest of the code is also subject to the above comments.

...

Btw, somebody else already submitted the similar changes.


-- 
With Best Regards,
Andy Shevchenko