Re: [PATCH v13 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode

From: Dmitry Baryshkov
Date: Mon Jul 28 2025 - 14:30:07 EST


On 28/07/2025 18:54, Shivendra Pratap wrote:


On 7/28/2025 5:53 PM, Krzysztof Kozlowski wrote:
On 28/07/2025 14:03, Dmitry Baryshkov wrote:

and the reboot-mode is defined in the
previous patch. So, I'd assume, the path is defined.

As I said, path is not. only psci/reboot-mode is.

Do we have an _actual_ use case where PSCI node is not at at root node?

Yes, many cases, because it belongs as well to firmware node.

If not, it's obviously a deficiency of the schema. Could you please
provide suggestions on how to describe that in DT schema?

I do not see deficiency. There is no ABI that psci must be root node, so
there is no issue to fix there.

If you want to add such ABI, I will answer: no, don't, because we do not
want paths or node names to be the ABI.

Compatible is the ABI.
Will define a compatible for psci->reboot-mode node and use it to find the
node. Hope its fine to define a compatible for reboot-mode which is defined
as a property inside psci?

I think it was more about finding the PSCI node.


thanks.

Best regards,
Krzysztof


--
With best wishes
Dmitry