Re: [PATCH v15 01/10] unwind_user: Add user space unwinding API with frame pointer support

[Steven Rostedt]

On Mon, 28 Jul 2025 17:24:52 +0200
Jens Remus <jremus@xxxxxxxxxxxxx> wrote:

> 
> Reviewed-by: Jens Remus <jremus@xxxxxxxxxxxxx>

Thanks.

> 
> > diff --git a/kernel/unwind/user.c b/kernel/unwind/user.c  
> 
> > +static int unwind_user_next_fp(struct unwind_user_state *state)
> > +{
> > +	struct unwind_user_frame *frame = &fp_frame;  
> 
> Optional: Pointer to const?

Hmm, yeah, and we can easily make fp_frame a constant as it's only
updated by the arch macro and never modified.

> 
> > +	unsigned long cfa, fp, ra = 0;  
> 
> Nit: Is initialization of ra really required?  I don't see where ra
> would be getting used without being set beforehand.

That's probably leftover.

These are minor changes, I'll update.

Thanks for the review.

-- Steve