Re: [PATCH v5 8/9] rv: Add nrp and sssw per-task monitors
From: Nam Cao
Date: Mon Jul 28 2025 - 11:56:21 EST
On Mon, Jul 28, 2025 at 03:50:20PM +0200, Gabriele Monaco wrote:
> Add 2 per-task monitors as part of the sched model:
>
> * nrp: need-resched preempts
> Monitor to ensure preemption requires need resched.
> * sssw: set state sleep and wakeup
> Monitor to ensure sched_set_state to sleepable leads to sleeping and
> sleeping tasks require wakeup.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>
I can't comment on the model, but the monitor implementation looks okay. I
ran the two monitors on x86, powerpc64, riscv64 and didn't see anything
suspicious:
Acked-by: Nam Cao <namcao@xxxxxxxxxxxxx>
Tested-by: Nam Cao <namcao@xxxxxxxxxxxxx>