Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.

[Marco Elver]

On Mon, 28 Jul 2025 at 12:43, Dishank Jogi <jogidishank503@xxxxxxxxx> wrote:
>
> ---------------------------------------------------------
>
> - Removed unnecessary trailing commas from DEFINE_TSAN_ATOMIC_RMW() macro
>   calls within DEFINE_TSAN_ATOMIC_OPS() in kernel/kcsan/core.c
>
> - It passes checkpatch.pl with no errors or warnings and
>   introduces no functional changes.
>
> ---------------------------------------------------------
>
> Signed-off-by: Dishank Jogi <jogidishank503@xxxxxxxxx>

Nack.

Did you compile the kernel with this?

> ---
>  kernel/kcsan/core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
> index 8a7baf4e332e..f2ec7fa4a44d 100644
> --- a/kernel/kcsan/core.c
> +++ b/kernel/kcsan/core.c
> @@ -1257,12 +1257,12 @@ static __always_inline void kcsan_atomic_builtin_memorder(int memorder)
>  #define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
>         DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
>         DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits, );                                                  \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits, );                                                \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>         DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
>         DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
>         DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
> --
> 2.43.0
>