Re: [PATCH net-next v2 4/4] net: phy: micrel: Add support for lan8842

[Horatiu Vultur]

The 07/26/2025 17:23, ALOK TIWARI wrote:

Hi Alok,

> 
> On 7/25/2025 1:38 AM, Horatiu Vultur wrote:
> > +static void lan8842_get_phy_stats(struct phy_device *phydev,
> > +                               struct ethtool_eth_phy_stats *eth_stats,
> > +                               struct ethtool_phy_stats *stats)
> > +{
> > +     struct lan8842_priv *priv = phydev->priv;
> > +
> > +     stats->rx_packets = priv->phy_stats.rx_packets;
> > +     stats->rx_errors = priv->phy_stats.rx_errors;
> > +     stats->tx_packets = priv->phy_stats.tx_packets;
> > +     stats->tx_errors = priv->phy_stats.rx_errors;
> 
> looks like a copy-paste mistake
> stats->tx_errors = priv->phy_stats.tx_errors;

That is a good catch!
I will fix it in the next version.

> 
> > +}
> > +
> 
> 
> Thanks,
> Alok

-- 
/Horatiu