Re: [PATCH] xen: Rename xenmem_reservation_increase to xenmem_populate_physmap

From: Jürgen Groß
Date: Mon Jul 28 2025 - 01:50:36 EST


On 25.07.25 12:12, Teddy Astie wrote:
xenmem_reservation_increase currently calls XENMEM_populate_physmap.
Rename the function to avoid confusion with XENMEM_increase_reservation.

Hmm, I'm not convinced this is a good move.

xenmem_reservation_increase() has the counterpart xenmem_reservation_decrease(),
which shouldn't change its name.

So for the caller the naming is consistent. It is just the implementation which
is using a different hypercall. IMO such a detail should not be propagated to
higher logical levels.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature