Re: [PATCH] virtio_ring: fix uninitialized used value

[Jason Wang]

On Fri, Jul 25, 2025 at 9:12 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
>
> On Fri, Jul 25, 2025 at 04:36:35PM +0800, Jason Wang wrote:
> > Buildbot reports uninitialized used:
> >
> > drivers/virtio/virtio_ring.c:2113:40: error: variable 'id' is
> > uninitialized when used here [-Werror,-Wuninitialized]
> >  2113 |                 BAD_RING(vq, "id %u out of range\n", id);
> >       |                                                      ^~
> > drivers/virtio/virtio_ring.c:2077:19: note: initialize the variable
> > 'id' to silence this warning
> >  2077 |         u16 last_used, id, last_used_idx;
> >       |                          ^
> >       |                           = 0
> > 1 error generated.
> >
> > Fixing this by use last_used instead and drop the complete unused
> > variable id.
> >
> > Cc: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
> > Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Reported-by: kernelci.org bot <bot@xxxxxxxxxxxx>
> > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
>
> I squashed but I think you should respin.
> also noticed a couple of minor issues.
>

I think a reppin of this patch should be sufficient.

I can post a new version.

Thanks