Re: [PATCH] net: atlantic: fix overwritten return value in Aquantia driver
From: Andrew Lunn
Date: Sun Jul 27 2025 - 22:50:04 EST
On Sun, Jul 27, 2025 at 04:17:50PM -0700, Tian wrote:
> From: tian <27392025k@xxxxxxxxx>
>
> In hw_atl_utils.c and hw_atl_utils_fw2x.c, a return value is set and then
> immediately overwritten by another call, which causes the original result
> to be lost. This may hide errors that should be returned to the caller.
>
> This patch fixes the logic to preserve the intended return values.
Please include in the commit message why it is safe to OR together two
error codes.
Andrew