Re: [PATCH] platform/x86: surfacepro3_button: replace deprecated strcpy() with strscpy()

[Chen, Yu C]

On 7/28/2025 4:32 AM, Ilpo Järvinen wrote:
> On Thu, 24 Jul 2025, Miguel García wrote:
>
> > strcpy() is deprecated for NUL-terminated strings. Replace it with
> > strscpy() to guarantee NUL-termination. 'name' is a fixed-size local
> > buffer.
> >
> > Signed-off-by: Miguel García <miguelgarciaroman8@xxxxxxxxx>
> > ---
> >   drivers/platform/surface/surfacepro3_button.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/surface/surfacepro3_button.c b/drivers/platform/surface/surfacepro3_button.c
> > index 2755601f979c..9616548283a1 100644
> > --- a/drivers/platform/surface/surfacepro3_button.c
> > +++ b/drivers/platform/surface/surfacepro3_button.c
> > @@ -211,7 +211,7 @@ static int surface_button_add(struct acpi_device *device)
> >   	}
> >   
> >   	name = acpi_device_name(device);
> > -	strcpy(name, SURFACE_BUTTON_DEVICE_NAME);
> > +	strscpy(name, SURFACE_BUTTON_DEVICE_NAME, sizeof(name));
>
> strscpy() should nowadays support 2 args variant through clever macro
> trickery.

Yup,  something like
strscpy(name, SURFACE_BUTTON_DEVICE_NAME);
should be fine, because
name is a array, and SURFACE_BUTTON_DEVICE_NAME is smaller than
the size of name.

thanks,
Chenyu